The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ionic-framework	Ready	Preview, Comment	Feb 17, 2026 6:46pm

@ShaneK there's tests that check that the parts are working as intended.

@ShaneK there's tests that check that the parts are working as intended.

That is true, but in many other tests for parts we test with visual regression tests specifically. The fact tests existed at all is why I went ahead and approved and called it a minor concern.

@ShaneK there's tests that check that the parts are working as intended.

That is true, but in many other tests for parts we test with visual regression tests specifically. The fact tests existed at all is why I went ahead and approved and called it a minor concern.

That makes sense, but @brandyscarney has made good points of why we shifted over to use this new approach to test parts. I just can't seem to remember what it was. Maybe less snapshots for us to maintain?

Sorry I missed your previous comments.

We don't need screenshot tests here since we're defining the colors ourselves. If these were the default colors for the elements we would verify them visually to ensure they look correct because the defaults may change frequently. Because we're defining what color the token should use we can just verify that the right element is styled by it.